all: fixed integration tests for ydb#11
Merged
kprokopenko merged 46 commits intoydb-platform:ydb-developfrom Feb 4, 2026
Merged
all: fixed integration tests for ydb#11kprokopenko merged 46 commits intoydb-platform:ydb-developfrom
kprokopenko merged 46 commits intoydb-platform:ydb-developfrom
Conversation
LostImagin4tion
force-pushed
the
LostImagin4tion/fix-integration-tests
branch
10 times, most recently
from
0cefedb to
02e2a25
Compare
LostImagin4tion
force-pushed
the
LostImagin4tion/fix-integration-tests
branch
from
02e2a25 to
c266bf3
Compare
LostImagin4tion
force-pushed
the
LostImagin4tion/fix-integration-tests
branch
from
0c5e907 to
65272ba
Compare
LostImagin4tion
commented
Feb 4, 2026
Comment on lines
+84
to
+97
| func unwrapYDBDriver(driver any) *entdrv.YDBDriver { | ||
| switch drv := driver.(type) { | ||
| case *entdrv.YDBDriver: | ||
| return drv | ||
| case *YDB: | ||
| return unwrapYDBDriver(drv.Driver) | ||
| case *WriteDriver: | ||
| return unwrapYDBDriver(drv.Driver) | ||
| case *dialect.DebugDriver: | ||
| return unwrapYDBDriver(drv.Driver) | ||
| } | ||
| return nil | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
поправлю этот ужас в следующем пре (вместе с Open)
LostImagin4tion
commented
Feb 4, 2026
| // YDB has strong typing system | ||
| // and YDB driver can't convert type aliases to underlying Go type | ||
| // Therefore, we have to manually handle these edge cases | ||
| func (b *Builder) convertValueYdb(arg any) any { |
Collaborator
Author
There was a problem hiding this comment.
вот это еще один ужас, возможно, тут надо созвониться, чтобы обсудить)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.